DeclaredType in TypeChecker #2008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Nov 1, 2024
chriseth
reviewed
Nov 1, 2024
chriseth
reviewed
Nov 1, 2024
Co-authored-by: chriseth <[email protected]>
Co-authored-by: chriseth <[email protected]>
chriseth
reviewed
Nov 4, 2024
chriseth
reviewed
Nov 4, 2024
chriseth
reviewed
Nov 7, 2024
chriseth
reviewed
Nov 7, 2024
chriseth
reviewed
Nov 7, 2024
|
This looks very good now, thanks! Now my main remaining question is: Can we turn the two enums into a single one? |
Do you mean DeclaredType and DeclaredTypeKind? Maybe adding the type and an Option<HashMap<...>> to DeclaredType? I find the Option more cumbersome than having another Enum, but whatever you prefer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Struct integration (mainly typing), we need to improve the way “declared types” are handled so that we can type struct fields without passing new data structures to type checking.
This PR introduces the necessary modification to then add Struct typing on top of it, preventing #1910 from being huge.